ensure no implicit casts are done for packet.kf_vx packing#129
Draft
mariano-f-r wants to merge 1 commit intomainfrom
Draft
ensure no implicit casts are done for packet.kf_vx packing#129mariano-f-r wants to merge 1 commit intomainfrom
mariano-f-r wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft of a PR to finish an issue tracked on the onboarding issue tracker.
Description
This first bit of code ensures no implicit casting is done. Testing will be done to determine if this fixes the issue or if it's bad KF data.
Once those items are done, this draft will be finalized and turned into a complete PR, ready for review.